I've tested this a bit with grunt build-app and node server.js --console. Apart from the issue mentioned above, the only thing I'm missing is the demo file (formerly index.html in root). This was useful to verify all the JS and CSS is there and that the theme looks right. Kind of like a MANIFEST with hashes but for manual testing. @scottgonzalez any thoughts on keeping that? We didn't discuss this particular file in #207.

Yeah, we should probably keep that. It's really useful for quick testing and serves as a simple starting point for users.

Alright. @rxaviers can you bring that back (the code is still there, anyway) and fix the other issue? I'll do another test run then, including building packages for release script and jqueryui.com.

Another thing I just thought of is whether we should include theme.css so users can easily include multiple themes without duplication.

We'll include structure + theme + concat.

Fixed. Ready for a new review.

To check that 1.11.0-beta.2 will list selectmenu, I update config.json to point at master for the Pre-Release. After running grunt prepare, I still don't get selectmenu in the list of widgets. Since there isn't an error about missing manifest files, why is it showing the other components just fine, but not selectmenu?

My test download for jquery-ui-1.11.0-beta.1.custom didn't include the index.html file, can you add that back?

Looking at the banners, the js and css files are looking good. Would be a lot easier to test that properly with the demo file.

I also logged #216 while testing this, which seems even more useful with the separate structure css files.

I completely forgot to add index.html back 😳, sorry. Here it is now.

To check that 1.11.0-beta.2 will list selectmenu, I update config.json to point at master for the Pre-Release. After running grunt prepare, I still don't get selectmenu in the list of widgets. Since there isn't an error about missing manifest files, why is it showing the other components just fine, but not selectmenu?

Interesting. Mine did included it just fine. A couple of differences I used: origin/master instead of master (but, both should work).

I tried again with origin/master, that worked. Did some more test downloads, with all components and just selectmenu (and dependencies) and standard and custom theme.

The only thing missing is a selectmenu demo in index.html. Everything else looks good.

I've fixed the missing demo. Could leave that commit as-is or squash it into something else. Will do some more testing with jqueryui.com and the release script...

Found an unrelated issue, reported in #218.

My local installation of jqueryui.com is messed up, it takes hours to deploy to the site and I have no idea why.

I also tried to test this as part of the release script. In my standalone script, building the CDN package just stopped without any error. It took a while to try the same with the regular script, but that failed with the same issue, whatever it actually is.

@rxaviers can you try to debug this? Go to your jquery-ui repo and put this in build/test-release.js:

var shell = require( "shelljs" );
var Release = {
    exec: shell.exec,
    abort: function( msg ) {
        console.error( msg );
        process.exit( 1 );
    },
    define: function( definitions ) {
        for ( var key in definitions ) {
            Release[ key ] = definitions[ key ];
        }
    },
    newVersion: "1.11.0-beta2"
};
var script = require("./release");
script( Release );
Release.generateArtifacts(function() {
    console.log( "Done generating artifacts", arguments );
});

Link DB (npm link download.jqueryui.com) and install shelljs (npm install shelljs@0.2.6), then run the script with node build/test-release.js. The last line logged should be "Building CDN package", afterwards it just stops without any error.

When I tried to track this down I found that it gets until here: https://github.com/jquery/download.jqueryui.com/blob/fix-207-simplify-package/lib/themes-packer.js#L64

build.commonFiles is undefined, which causes this to fail, but I have no idea why it is undefined or why there is no output.

@jzaefferer thanks for extensively testing this branch and for finding (and adding) the missing selectmenu demo.

As for the release script, it won't be able to use the simpler builder to build non-simpler CDN packages. We need discuss how we want CDN packages to be. Is it going to reflect our simpler download package changes?

@jzaefferer, d3a75eb reverts the pieces of builder 1.11 that can't go away, because it's used by ThemePacker (used by cdn package). Now, release script should work just fine.

I've created a separate ticket #219, so we create unit tests for ThemePacker.

Updated description to include the .structure, .theme, and index.html files.

Tested this again, with the local server, release script and deployment to local jqueryui.com. My local site isn't working that well (I can't test WordPress /resources/ properly). But based on the files in the filesystem etc. everything looks good now. Let's land this and do some more testing on stage, then we should be good to release beta.2.

All squashed

On http://stage.jqueryui.com/

Looks good.